On Wed, 23 Jun 2004, Beau E. Cox wrote:
Hi all -
This is the first time I have gotten an 'unexpectedly succeeded' result from mod_perl's 'make test':
... t/filter/out_str_ctx....................ok t/filter/out_str_declined...............ok t/filter/out_str_eval...................ok 1/1 unexpectedly succeeded t/filter/out_str_lc.....................ok t/filter/out_str_remove.................ok t/filter/out_str_req_eos................ok t/filter/out_str_req_mix................ok ...
I'm not sure why the test is marked as it is, but this: ========================================================== Index: t/filter/TestFilter/out_str_eval.pm =================================================================== RCS file: /home/cvs/modperl-2.0/t/filter/TestFilter/out_str_eval.pm,v retrieving revision 1.1 diff -u -r1.1 out_str_eval.pm --- t/filter/TestFilter/out_str_eval.pm 5 Jun 2004 05:05:21 -0000 1.1 +++ t/filter/TestFilter/out_str_eval.pm 24 Jun 2004 13:31:56 -0000 @@ -25,7 +25,7 @@ sub response { my $r = shift;
- plan $r, tests => 1, todo => [1]; + plan $r, tests => 1; # XXX: see if we can fix filter handlers to restore the original # $@ when the callback completes eval { i_do_not_exist_really_i_do_not() };
================================================================== will get rid of the "unexpectedly succeeded" message.
What really happened is that the recent change in t_cmp implementation, hid the problem. The problem is still there, but the test now succeeds. I will fix the test to fail again.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
-- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html
