> How is that related?

i think that's some cargo culting that i didn't clean up. that can
be disregarded.

> So you think this approach will be faster than flattening bb on each 
> filter invocation and concatenating the scalar?

honestly i didn't give it any thought. when i wrote this i just
wanted to make it go.

> sub Apache::SubRequest::run_trapped {
>     my ($r, $sref) = @_;
> [...]
>     $bb->flatten(my $data);
>     $$sref = $data;
>     $rv;
> 
> why not make the API that does run_trapped($data) and save the copying of 
> what could be a huge data with:
> 
> sub Apache::SubRequest::run_trapped {
>     my $r = shift;
> [...]
>     $bb->flatten($_[1]);

yeah that makes significantly more sense. i'll update that soon.

.d

Reply via email to