Re: [RELEASE CANDIDATE] Apache-SizeLimit 0.91 RC1

[Fred Moyer]

Philip M. Gollucci wrote:
Fred Moyer wrote:
Philip M. Gollucci wrote:
A release candidate for Apache-SizeLimit 0.91-RC1 is now available.
http://people.apache.org/~pgollucci/asl/Apache-SizeLimit-0.91-rc1.tar.gz

Here's my suggested patch to handle this.  Only problem is it doesn't 
tell you why it skipped - I know why but I don't count...
You know it helps if I read the e-mail first. I don't have darwin handy 
give it a spin, add Changes and commit -- or yell that I broke it more.

Committed revision 483365 with one minor change, I used eq 'darwin' 
instead of eq /darwin/ due to a use of uninitialized value in pattern 
match warning.  I'm guessing that's because $Config is read only.  Test 
skips successfully now on darwin with a nice message why it skips.

Thanks Philip.


/home/pgollucci/dev/repos/asf/perl/Apache-SizeLimit/trunk 240 0 >

svn diff t
Index: t/apache/all.t
===================================================================
--- t/apache/all.t      (revision 482929)
+++ t/apache/all.t      (working copy)
@@ -25,6 +25,11 @@
     elsif ( $Config{'osname'} eq 'MSWin32' ) {
         $ok &= need_module('Win32::API');
     }
+    elsif ( $Config{'osname'} eq /darwin/ ) {
+        push @Apache::Test::SkipReasons,
+            "$Config{osname} is not supported - broken getrusage(3)";
+        return 0;
+    }

     $ok &= need_module('mod_perl.c');

Index: t/apache2/all.t
===================================================================
--- t/apache2/all.t     (revision 482929)
+++ t/apache2/all.t     (working copy)
@@ -25,7 +25,13 @@
     elsif ( $Config{'osname'} eq 'MSWin32' ) {
         $ok &= need_module('Win32::API');
     }
+    elsif ( $Config{'osname'} eq /darwin/ ) {
+        push @Apache::Test::SkipReasons,
+            "$Config{osname} is not supported - broken getrusage(3)";
+        return 0;
+    }

     $ok &= need_min_apache_version("2.0.48");

     eval { require mod_perl2; };