Can you submit these patches inline? http://perl.apache.org/docs/2.0/devel/help/help.html#Submitting_Patches
When they are attachments like this, people tend to not read them. Whereas when they are inline, people tend to be able to read them and comment very easily. On Tue, Feb 2, 2010 at 1:58 PM, Max Kanat-Alexander <mka...@bugzilla.org> wrote: > All of my processes kept exiting with a report that they had a 300M > unshared size, which was clearly untrue, even from looking at top. After > some investigation, I discovered that Apache2::SizeLimit was calling > $s->size on the Linux::Smaps object, when instead it should be returning > $s->rss as the process size. > > Attached is a one-line patch to fix the issue. > > Also, if you're interested in proof that this is right, I've attached a > short .cgi file that you can load under mod_perl, with Linux::Smaps > installed, to see process sizes and the return values of all of the > Smaps accessors. > > -Max > -- > http://www.everythingsolved.com/ > Competent, Friendly Bugzilla and Perl Services. Everything Else, too. >
