On 10-02-09 16:30 , Fred Moyer wrote: > Greetings, > > Please, download, test, and report back on success or failure for this > Apache::Test release candidate. > > Development from 1.30 has been ongoing for about two years, so this is > as good a time as ever to make a release. > > http://people.apache.org/~phred/Apache-Test-1.31-rc2.tar.gz
Passes all tests on OSX/10.6 Apache/2.2.13/prefork mod_perl/2.0.4
Perl/v5.10.0
One small nit, not sure why, but t/next_available_port.t was modified
and will only be run if mod_cgi *and* mod_cgid is installed, which is
not very likely. Shouldn't this be what it does instead ?
diff -rdu Apache-Test-1.31-rc2/t/next_available_port.t
Apache-Test-1.31-rc2.test/t/next_available_port.t
--- Apache-Test-1.31-rc2/t/next_available_port.t 2009-04-18
05:59:26.000000000 -0400
+++ Apache-Test-1.31-rc2.test/t/next_available_port.t 2010-02-09
21:20:26.000000000 -0500
@@ -7,8 +7,7 @@
use Apache::TestRequest;
use Apache::TestUtil;
-plan tests => 1, need need_module('mod_cgi.c'),
- need_module('mod_cgid.c'),
+plan tests => 1, need need_cgi,
need_module('mod_env.c');
my $url = '/cgi-bin/next_available_port.pl';
Looking at Changes, I can see
"Use need_module('mod_cgi.c') and need_module('mod_cgid.c') in
t/next_available_port.t instead of need_cgi. On case insensitive file
systems such as OS X, need_cgi will fulfill the requirement with cgi.pm,
when mod_cgi.c is the desired requirement.
[Fred Moyer <ph...@apache.org>]"
Wouldn't the correct solution be to fix need_cgi then :
diff -ru Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm
Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm
--- Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm 2010-02-09
13:21:39.000000000 -0500
+++ Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm 2010-02-09
21:27:47.000000000 -0500
@@ -348,7 +348,7 @@
}
sub need_cgi {
- return _need_multi(qw(cgi cgid));
+ return _need_multi(qw(cgi.c cgid.c));
}
--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature
