# from John Peacock
# on Sunday 28 January 2007 10:56 am:

>Eric Wilhelm wrote:
>> Is the Scalar::Util dependency justified?
>The patch is *removing* the dependency on Scalar::Util and *adding*
> dependencies on locale and POSIX.

My bad.  I blame late-night diff reading.

>> Taking advantage of $_[1] being an alias to $VERSION in import()
>> seems a little sneaky, and possibly fragile.
... 
> shove the value into the correct scalar.  One thing I neglected to
> point out is that this would work as well:
>
>       use version $VERSION => qv($Revision: 1.2$);

I'll guess that's supposed to be qw().  No qv before import?

>> What about  >>   use version $VERSION = 1.2.0;
>> $_[0] = version->new($_[0]); ?
>
>That wouldn't work with the CVS-style initializer as I described
> above.  I don't know how many people are still using that mode, but I
> need to get the parameters as a list, not an inline assignment, in
> order for both methods to work.

  use version $VERSION = qw$Revision: 1.2$[1];

What's different about cvs versions?

--Eric
-- 
The only thing that could save UNIX at this late date would be a new $30
shareware version that runs on an unexpanded Commodore 64.
--Don Lancaster (1991)
---------------------------------------------------
    http://scratchcomputing.com
---------------------------------------------------

Reply via email to