On Apr 18, 2007, at 10:01 PM, Eric Wilhelm wrote:

# from Ken Williams
# on Wednesday 18 April 2007 06:48 pm:

What I'd like
to do is add an option during 'Build dist' that rewrites all
'$VERSION = whatever' assignments to a static version.  Determined
through the usual route of dist_version_from or dist_version.

Why in ACTION_dist()?  It seems like a pm_files/ACTION_code() (or just
ACTION_bumpversion or ACTION_setversion) thing to me. I guess I expect
installing from svn and tarball to do the same thing.

That makes a certain amount of sense, but I think it would be nice if the developer could perform that task once and for all, so that the rest of the world doesn't have to. It's not something a user should have to care about performing.

So I think that means it should either be in ACTION_dist(), or a developer-only action that operates right on the files in lib/ (or wherever they sit). Actually, I like that latter even better. Then svn & tarball are the same thing, *and* the end user never has to care.


Maybe start with some pieces like set_version($modpath, $version) and
match_version($source_modpath, [EMAIL PROTECTED]).  Then see how/if
people are using it?

That's a good idea.


 -Ken

Reply via email to