# from Andreas J. Koenig # on Sunday 15 July 2007 07:50 am: >I hope this can go into Module::Build.
Possibly I don't understand the issue well enough, but ... It sounds like we're fixing a bug which only exists in a specific set of bleadperl revisions which are only of interest for internal development. That is, it will never appear in the wild? If so, is there a good way that we can enable what you need without maintaining this code forever? My main concern is the added complexity, plus the "wtf?" factor. Given that we have a very small compatibility target, it seems like pushing the complexity into that arena (via a history file or setup code) would be more efficient. Is there any reason that your need couldn't be met with a frozen version of M::B? If that works, does it need to be on CPAN? (e.g. can it be 0.280_8 or something?) Does the distro even need to be named Module-Build? That is, if you're not smoke-testing from a "bare perl", you could just preload Module-Build-blead23190..25414.tar.gz or whatever? If something like the above will do the trick, let's do that please. >+ my $vd = eval { sprintf "%vd", $^V }; >+ # broken in [EMAIL PROTECTED] >+ return $] if $@; >+ return $^V ? $self->perl_version_to_float($vd) : $]; Even that ^-- is a lot to explain to a future maintainer, and it's quite likely one of us won't be handy to explain it. But this one, would just make my eyes pop out. >- if (defined($^V) && ord(substr($^V,1)) >= 8) { >- $varchname .= sprintf("-%d.%d", ord($^V), ord(substr($^V,1))); >+ my $ord_substr_v1 = eval { ord(substr($^V,1)) }; >+ if ($@) { >+ # broken in [EMAIL PROTECTED] >+ $ord_substr_v1 = int(1000*($] - int($]))); >+ $@ = ''; > } >+ my $ord_v = eval { ord($^V) }; >+ if ($@) { >+ # broken in [EMAIL PROTECTED] >+ $ord_v = int($]); >+ $@ = ''; >+ } >+ if (defined($^V) && $ord_substr_v1 >= 8) { >+ $varchname .= sprintf("-%d.%d", $ord_v, $ord_substr_v1); >+ } > return $varchname; > } Thanks, Eric -- The opinions expressed in this e-mail were randomly generated by the computer and do not necessarily reflect the views of its owner. --Management --------------------------------------------------- http://scratchcomputing.com ---------------------------------------------------