# from Zefram
# on Thursday 25 October 2007 12:31:
>Eric Wilhelm wrote:
>>1. I think we should officially deprecate dir WRT Build.PL
>>2. This code will put them both in META.yml if they both exist.
>
>That's a weird situation that should never occur: it's invalid input
>data under any version of the spec.
We only get 'should never occur' if we implement "die if both" per #1.
> I'd have done it differently if
> M::B were validating the input, or otherwise taking measures to
> generate only strictly valid output.
Yep. That's something we need to work toward. File it in RT?
>>3. why bother with the dereference?
> $no_index = { %$no_index };
> This is to avoid modifying a hash that was supplied as an argument.
In that case, it should be outside of the if(... 'dir' ...) conditional.
--Eric
--
The opinions expressed in this e-mail were randomly generated by
the computer and do not necessarily reflect the views of its owner.
--Management
---------------------------------------------------
http://scratchcomputing.com
---------------------------------------------------
