Agreed. Indefinite retry is not a good idea, but limited retry should cover almost every case that is laggy without preventing legitimate failures from happening.
Adam K 2009/1/15 Jan Dubois <[email protected]>: > On Wed, 14 Jan 2009, David Golden wrote: >> On Wed, Jan 14, 2009 at 7:16 PM, Adam Kennedy >> <[email protected]>wrote: >> >> > If the "delete pending" thing is detectable, we could even just fix it >> > in error handling. >> > >> > if ( $@ =~ /delete pending/ ) { >> > print "Waiting for files to delete...\n"; >> > sleep(5); >> > run_it_again(); >> > } >> > >> >> It's not a consistent error message, I think. That error shows up deep in >> File::Path and the resulting error is usually about not being able to delete >> because of permissions. > > You only get the "delete pending" error when you try to create or open a > file which is still being deleted. You don't get the error when you try > to delete the directory after deleting all files in it; you just get the > "directory not empty" error in that case. > > I can't think of a solution that either has the potential to hang (retry > indefinitely) or might not wait long enough if the machine is really busy. :( > > Just retrying to remove the directory every second for 20 seconds might > be a good compromise to cut down on false cpan testers reports. > > Cheers, > -Jan > >
