On Thu, Aug 27, 2009 at 6:39 PM, Eric Wilhelm<enoba...@gmail.com> wrote:
> # from dagol...@cvs.perl.org
> # on Tuesday 25 August 2009 13:30:
>
>>Log:
>>Fix t/destinations.t segfault on 5.6.2
>
>>-    local $mb->install_sets->{site} = \%test_config;
>>+    my $old =  $mb->install_sets->{site} = \%test_config;
> ...
>>+    $mb->install_sets->{site} = $old;
>
> Hi David,
>
> Is that really what you intended?  The log sounds like you wanted to
> workaround a local() bug, but this code changes the value of site
> rather than restoring it.

Bah.  Not what I intended.  Tests pass, though.  :-)

Thanks for spotting my haste/stupidity.

-- David

Reply via email to