Responses inline: On Thu, Apr 19, 2012 at 7:59 PM, Graham Dumpleton < [email protected]> wrote: > > First off, the bucket brigade will be cleaned up in as much no memory > will leak because of how Apache memory pooling works. >
I mostly changed it because that is how I've seen other apache modules do it. I'll believe you if you say that the brigade won't leak. I hate reading APR documentation As for whether messages, when yielding response from an application, > either way a message is going to end up in the logs and nothing more. > Your issue therefore seems to be the log level of messages in logs and > your wanting to hide them as much as possible. > > My recollection of why it is done the way it is is that an error at > that point can actually indicate a problem in the Apache output filter > chain and doesn't just mean that an error occurred in sending data to > the client. Unfortunately mod_ssl seems to indicate errors when issue > was a closed client connection because SSL will flag an error if in > middle of some SSL exchange. > > In other words, one should necessarily be masking what could be a true > actual error or problem rather than just noise. I would really need to > try and find old emails about this as has been discussed before. > It *could* be an actual problem. But, in practice over an enormous number of requests, it seems to happen almost any time a client disconnects mid-write (and, no, we're not using mod_ssl), and having all of these errors in our log was actually masking more actual problems than hiding them would. If nothing else, it would be nice to make there be a configuration flag to avoid printing enormous amounts of this spam for configurations where we know there's nothing interesting farther down the filter chain. -- James Brown Systems Engineer Yelp, Inc. -- You received this message because you are subscribed to the Google Groups "modwsgi" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/modwsgi?hl=en.
