Simple fix. Didn't even take 10 minutes. I can't push up to github from where I am as no SSH access, but will do it later so can at least verify.
As for whether the old way is better on system with small IOV_MAX not sure. The old way was doing a lot of stuffing around with trying to coalesce it all into a single memory buffer, so would use more memory plus the memory copies. That would be balanced against approximately half a dozen writev() calls versus one write() call. One would though think that the system calls are still more expensive. I will need to think best way of dealing with it. Solaris is probably the only system where it might crop up. Graham On 24 March 2015 at 15:22, Graham Dumpleton <[email protected]> wrote: > Yes. Will look at it while watching daughter doing gymnastics this > afternoon. > > Sent from my iPhone > > On 24/03/2015, at 3:10 PM, Jesus Cea <[email protected]> wrote: > > > On 24/03/15 05:03, Graham Dumpleton wrote: > >> I only started using writev in that way in version 4.4.0 I think. Am > out at moment so can't check. > > > > Will you take care of this?. I am not in a hurry to upgrade. 3.5 is fine > > so far. > > > > Looks like using "writev" to avoid overhead is going to add syscall > > overhead in Solaris (Solaris 11 has the same limit, just checked). The > > old approach looks more efficient :). > > > > -- > > Jesús Cea Avión _/_/ _/_/_/ _/_/_/ > > [email protected] - http://www.jcea.es/ _/_/ _/_/ _/_/ _/_/ _/_/ > > Twitter: @jcea _/_/ _/_/ _/_/_/_/_/ > > jabber / xmpp:[email protected] _/_/ _/_/ _/_/ _/_/ _/_/ > > "Things are not so easy" _/_/ _/_/ _/_/ _/_/ _/_/ _/_/ > > "My name is Dump, Core Dump" _/_/_/ _/_/_/ _/_/ _/_/ > > "El amor es poner tu felicidad en la felicidad de otro" - Leibniz > > > > -- > > You received this message because you are subscribed to the Google > Groups "modwsgi" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To post to this group, send email to [email protected]. > > Visit this group at http://groups.google.com/group/modwsgi. > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "modwsgi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/modwsgi. For more options, visit https://groups.google.com/d/optout.
