On 17/01/18 15:00, Graham Dumpleton wrote:
>> """ if (!PyErr_Occurred() && !aborted) { if (Adapter_output(self,
>> "", 0, NULL, 0)) self->result = OK; } """
>> 
>> I am not sure why "Adapter_output()" is called with NOOP operation 
>> (maybe to signal "end of stream", but then I don't know why it is
>> only done when no python error occurred), but "self->result=OK"
>> requires "aborted==0". This is not going to happen if we have
>> "aborted==1".
> 
> Apache needs it to ensure that a 100-continue response is flushed out
> correctly if browser was expecting it, otherwise things get messed
> up.

Then my question is why is that ONLY done when "!PyErr_Occurred()". It
should be done always, at least if "aborted==0".

> It sort of sounds plausible. I am travelling at the moment and don't
> have a good amount of time  to sit down and check it. For now just
> suggest keep testing with it and see how it goes. I will try and find
> some time over the next week to look at it more.

Much appreciated, Graham.

I have my patch in production. Good so far. Probably wrong if "100
continue", as described at the top of this email, but I don't use it. I
will implement it when you clarify.

-- 
Jesús Cea Avión                         _/_/      _/_/_/        _/_/_/
[email protected] - http://www.jcea.es/     _/_/    _/_/  _/_/    _/_/  _/_/
Twitter: @jcea                        _/_/    _/_/          _/_/_/_/_/
jabber / xmpp:[email protected]  _/_/  _/_/    _/_/          _/_/  _/_/
"Things are not so easy"      _/_/  _/_/    _/_/  _/_/    _/_/  _/_/
"My name is Dump, Core Dump"   _/_/_/        _/_/_/      _/_/  _/_/
"El amor es poner tu felicidad en la felicidad de otro" - Leibniz

-- 
You received this message because you are subscribed to the Google Groups 
"modwsgi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/modwsgi.
For more options, visit https://groups.google.com/d/optout.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to