Hi Florian, just some quick comments (I don't have any clue about crunchy, so these comments are just from a moin developer perspective):
macro/ExternalLink ================== I think everthing you are doing there can be also done by using moin 1.6/1.7 link syntax, e.g.: [[url|label|title=external_link]] (not sure about for what that title is useful, I rather would've expected some class=...) If you really need an own macro for this, maybe use the argument parser from wikiutil and don't do your own macro argument parsing). macro/LoadLocal and LoadRemote ============================== We have formatter.span(). parser/crunchy ============== Not sure you need that DummyRequest stuff, see wikiutil.RenderText and check if that would work for you. style/crunchy ============= Should be theme/crunchy. Config stuff should be in different directory. Both wikiconfigs have indentation errors at line 12. BTW, do you have some public demo site running your code? Cheers, Thomas ------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 _______________________________________________ Moin-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/moin-user
