On Mon, 10 Mar 2003 13:48:31 -0800 (PST), Jim Trocki <[EMAIL PROTECTED]> said:
>
> that is the perl module bundle.
Oops!
Strictures caught a bug in list_watch(), where the else branch is using
$l but I think it was meant to use $r.
The module still calls parse_line() in a number of places, though it
doesn't load Text::ParseWords so these fail. (Strictures don't catch
these because of the parens on the sub invocations (a good reason to go
paren-less).) No fix for that is attached; I don't know how you'd like
to handle it.
--- Mon/Client.pm.~1~ 2002-04-05 12:04:24.000000000 -0500
+++ Mon/Client.pm 2003-03-10 17:02:12.000000000 -0500
@@ -442,14 +442,22 @@
#
#
+use strict;
+
package Mon::Client;
require Exporter;
require 5.004;
use IO::File;
use Socket;
[EMAIL PROTECTED] = qw(Exporter);
[EMAIL PROTECTED] = qw(%OPSTAT $VERSION);
+use vars qw(@ISA @EXPORT_OK);
+
+BEGIN {
+ @ISA = qw(Exporter);
+ @EXPORT_OK = qw(%OPSTAT $VERSION);
+}
+
+use vars grep { /^\W/ } @EXPORT_OK;
$VERSION = "0.9901";
@@ -1110,7 +1118,7 @@
else
{
- $self->{"ERROR"} = $l;
+ $self->{"ERROR"} = $r;
return undef;
}
}
--
Roderick Schertler
[EMAIL PROTECTED]
_______________________________________________
mon mailing list
[EMAIL PROTECTED]
http://linux.kernel.org/mailman/listinfo/mon
