Hmmm, I'm not going to argue too strongly with you, the maintainer, on this
point - especially if there are other bugs to be ironed out - BUT I gotta
have my 2 cents worth...
the return()s from the eval{} block will only return as far as ftpGET()
which has the
if(!defined($result))
to catch a still undef'd hash.
> -----Original Message-----
> From: Jim Trocki [mailto:[EMAIL PROTECTED]
> Sent: 17 March 2003 16:39
> To: Dan Kendall
> Cc: [EMAIL PROTECTED]
> Subject: Re: ftp.monitor
>
>
> On Mon, 17 Mar 2003, Dan Kendall wrote:
>
> > I've been having some troubles getting the ftp.monitor from
> v.0.99.2 to
> > detect the lack of an ftp server after a successful socket
> connection. The
> > script's eval block detects the problems okay but then the
> wrapping function
> > seems to drop the ball and just returns ok. This has
> perhaps already been
> > fixed but
>
> thanks for pointing that out. i had a look at the 0.99.2 ftp.monitor,
> and it has more bugs than the ones you pointed out. actually,
> your patch
> doesn't fix it in the proper way. ftpGET should return a hash
> containing
> an "ok" element (true or false) and an "error" element, which
> is the error
> string. assigning values to $result then doing "return 0" is
> pointless.
> it should do something like this:
>
> return {
> "ok" => 0,
> "error" => "this is what went wrong",
> };
>
> i'll fix it up, post the new one to the list, and include the update
> for 0.99.3.
>
_______________________________________________
mon mailing list
[EMAIL PROTECTED]
http://linux.kernel.org/mailman/listinfo/mon
