And some tip:
I actually liked to original order
config file
dbfarm
dbname
more than the new one
dbname
confige file
dbfarm
dbfarm and dbname are highly related and only make sense together;
hence, they should IMHO be listed together.
And since explicitely given --dbfarm= & --dbname= overrule the respective
contents/settings of the config file, they should IMHO appear after the
config file, dbname after dbfarm.
Stefan
On Tue, Jul 17, 2007 at 08:09:01AM +0200, Stefan Manegold wrote:
> On Tue, Jul 17, 2007 at 04:07:11AM +0000, Martin Kersten wrote:
> > Update of /cvsroot/monetdb/MonetDB5/src/tools
> > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv10293/tools
> >
> > Modified Files:
> > mserver5.mx.in
> > Log Message:
> > My penny to cleanup the welcome message.
>
> see my change below.
>
> Stefan
>
> > Index: mserver5.mx.in
> > ===================================================================
> > RCS file: /cvsroot/monetdb/MonetDB5/src/tools/mserver5.mx.in,v
> > retrieving revision 1.20
> > retrieving revision 1.21
> > diff -u -d -r1.20 -r1.21
> > --- mserver5.mx.in 16 Jul 2007 11:51:44 -0000 1.20
> > +++ mserver5.mx.in 17 Jul 2007 04:07:07 -0000 1.21
> > @@ -174,15 +174,15 @@
> > char *msg = mo_find_option(set, setlen, "monet_welcome");
> >
> > if (msg && strcmp(msg, "yes") == 0) {
> > - printf("# MonetDB Server v" VERSION "\n");
> > - printf("# based on GDK v%s\n", GDKversion());
> > - printf("# Copyright (c) 1993-2007 CWI, all rights reserved\n");
> > + printf("# MonetDB server v" VERSION "\n");
> > + printf("# Based on kernel v%s\n", GDKversion());
> > + printf("# Database serviced:%s\n", GDKgetenv("gdk_dbname"));
> ^^
> shouldn't there be a space for sake of (human) readability?
>
> > printf("# Compiled for %s/" SZFMT "bit with " SZFMT "bit OIDs
> > %s linked\n", HOST, (size_t) (sizeof(ptr) * 8), (size_t) (sizeof(oid) * 8),
> > linkinfo);
> > #ifdef MONET_GLOBAL_DEBUG
> > - printf("# config:%s\n", GDKgetenv("config"));
> > - printf("# dbfarm:%s\n", GDKgetenv("gdk_dbfarm"));
> > + printf("# Configuration:%s\n", GDKgetenv("config"));
> ^^
> shouldn't there be a space for sake of (human) readability?
>
> > + printf("# Database farm:%s\n", GDKgetenv("gdk_dbfarm"));
> ^^
> shouldn't there be a space for sake of (human) readability?
>
> > #endif
> > - printf("# dbname:%s\n", GDKgetenv("gdk_dbname"));
> > + printf("# Copyright (c) 1993-2007 CWI, all rights reserved\n");
> > printf("# Visit http://monetdb.cwi.nl/ for further
> > information\n");
> > }
> > }
>
>
> --
> | Dr. Stefan Manegold | mailto:[EMAIL PROTECTED] |
> | CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ |
> | 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 |
> | The Netherlands | Fax : +31 (20) 592-4312 |
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Monetdb-developers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/monetdb-developers
>
>
--
| Dr. Stefan Manegold | mailto:[EMAIL PROTECTED] |
| CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ |
| 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 |
| The Netherlands | Fax : +31 (20) 592-4312 |
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Monetdb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-developers
