Ying Zhang wrote:
> Update of /cvsroot/monetdb/pathfinder/runtime
> In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5919
>
> Modified Files:
> pathfinder.mx
> Log Message:
> check 'seqnr' before write into it.
> 'seqnr' is only used by xrpc.
>
> This might be the cause of failing tests due to segfault.
>
>
>
> U pathfinder.mx
> Index: pathfinder.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/pathfinder/runtime/pathfinder.mx,v
> retrieving revision 1.427
> retrieving revision 1.428
> diff -u -d -r1.427 -r1.428
> --- pathfinder.mx 8 Jul 2008 17:51:30 -0000 1.427
> +++ pathfinder.mx 11 Jul 2008 10:45:31 -0000 1.428
> @@ -5070,7 +5070,7 @@
> *(ctx->time_compile) = GDKusec() - usec;
>
> /* Done preparing the query. Time to (re-)execute the MIL tree */
> - if (xquery_tree_exec(ctx, prepfun->lt, 1)) {
> + if (xquery_tree_exec(ctx, prepfun->lt, 1) && seqnr) {
> *seqnr = (*ctx->xrpc_seqnr);
> return NULL;
> }
Is this really correct? Shouldn't this be:
if (xquery_tree_exec(ctx, prepfun->lt, 1)) {
if (seqnr)
*seqnr = (*ctx->xrpc_seqnr);
return NULL;
}
And you really don't need those parentheses around *ctx->xrpc_seqnr.
--
Sjoerd Mullender
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________ Monetdb-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-developers
