Fabian wrote: > Update of /cvsroot/monetdb/MonetDB5/src/modules/atoms > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22761 > > Modified Files: > rmtobj.mx > Log Message: > For what its worth, apply my diffs after merging Martin's changes. I > basically had the same fixes. > >
> @@ -86,11 +86,11 @@
> int
> RMTOtoString(str *retval, int *len, str handle)
> {
> - int hl = (int) strlen(handle)+1;
> + int hl = (int)strlen(handle) + 1;
> if (*len < hl) {
> if (*retval != NULL)
> GDKfree(*retval);
> - *retval = GDKmalloc(hl);
> + *retval = GDKmalloc(sizeof(char) * hl);
> }
> *len = hl;
> memcpy(*retval, handle, hl);
I've seen this kind of thing quite often, but I have to ask, why? The
standard says about the sizeof operator:
"When applied to an operand that has type char, unsigned char, or signed
char, (or a qualified version thereof) the result is 1."
So why bother multiplying with sizeof(char)?
--
Sjoerd Mullender
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Monetdb-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-developers
