On Tue, Jan 29, 2013 at 11:52 AM, Eric Wong <[email protected]> wrote: > Lin Jen-Shin <[email protected]> wrote: >> + opts.on("-N", "--no-default-middleware", >> + "no default middleware even if RACK_ENV is development") do |e| > > RACK_ENV=deployment also loads middleware, so I think it's more accurate > with: > > do not load middleware implied by RACK_ENV > > This also puts us back within the 80-column limit imposed by "test_help" > in test/exec/test_exec.rb
Oh right, I only remembered to keep the source within 80-column limit, but forgot that the output might be longer than source. Thanks for the better wordings. I updated the patch for Zbatery, but it's too late for Rainbows though. > Will sign-off and push that change squashed unless there are objections. Surely, thanks! > I also just bumped master to rack 1.5.1, which fixes the Rack::Lint > test regression in 1.5.0. > > Will pull in the "hijack" branch into master soon (and release 4.6.0) > since all my questions about it have been answered in rack-devel. I haven't had a chance to read hijack more, looking forward to it :) _______________________________________________ Unicorn mailing list - [email protected] http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying
