On Mon, Nov 25, 2013 at 5:20 PM, Eric Wong <[email protected]> wrote:
>> What I notice is the following: when upgrading with 4.6.2 the file >> unicorn.pid is copied to unicorn.pid.oldbin and the unicorn.pid file >> is updated (the (new) master process). After a while the worker pid >> files are updated and the unicorn.pid.oldbin file disappears, and all >> is fine. > > Ugh. This is what I feared... Slow startup time of most Ruby web apps > doesn't help. Why doesn't the new master write its pid file immediately upon forking? It shouldn't have to wait for everything else to load, should it? > How about having the old process create a hard link to .oldbin, > and having the new one override the pid if Process.ppid == pid file? > The check is still racy, but that's what pid files are :< If you decide to implement this, please make it optional. The current behavior is correct IMO, and it will work much better if the above issue is addressed. --Michael _______________________________________________ Unicorn mailing list - [email protected] http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying
