Thanks for the patch!, it has been applied to master. I have to modify it a little because i found mixed spaces and tabs, please use Vim or Emacs for file edition.
regards, On Tue, Mar 20, 2012 at 12:43 PM, Mahesh Gondi <[email protected]> wrote: > fixed the commit again > > > On Tue, Mar 20, 2012 at 11:44 PM, Mahesh Gondi <[email protected]> wrote: >> >> commit fixed. >> >> >> On Tue, Mar 20, 2012 at 11:24 PM, Mahesh Gondi <[email protected]> wrote: >>> >>> thanks, :) >>> >>> will fix that >>> >>> >>> On Tue, Mar 20, 2012 at 11:13 PM, Eduardo Silva <[email protected]> >>> wrote: >>>> >>>> Hi Mahesh! >>>> >>>> thanks for your patch! good catch, as we did not tried Android tool >>>> chain with the last release we did not catch this. >>>> >>>> I need to request you a minor changes to accept your patch: >>>> >>>> - We do not use tabs, we use spaces, each tab is 4 spaces. Please >>>> use a text editor which understand the indentation rules specified at >>>> the first line of each .c or .h >>>> - on every conditional we use the { in the same line, not in the next, >>>> e.g: >>>> >>>> if (something) { >>>> ... >>>> } >>>> else { >>>> .... >>>> } >>>> >>>> please do that minor changes and resubmit your patch, >>>> >>>> cheers! >>>> >>>> On Tue, Mar 20, 2012 at 11:31 AM, Mahesh Gondi <[email protected]> >>>> wrote: >>>> > Greetings, >>>> > >>>> > replaced deprecated err() calls with mk_err(). >>>> > >>>> > Regards, >>>> > Mahesh Gondi, >>>> > IT-BHU, India. >>>> > >>>> > _______________________________________________ >>>> > Monkey mailing list >>>> > [email protected] >>>> > http://lists.monkey-project.com/listinfo/monkey >>>> > >>>> >>>> >>>> >>>> -- >>>> Eduardo Silva >>>> http://edsiper.linuxchile.cl >>>> http://www.monkey-project.com >>> >>> >> > -- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
