make sure to do not break IPv6 support :) On Sat, Mar 24, 2012 at 8:08 PM, Sourabh Chandak <[email protected]> wrote: > Jean-Paul, > > The first fix that you have given, about changing the default value > of MK_DEFAULT_LISTEN_ADDR, I guess its not a good idea because that will > restrict the socket to listen to only localhost upon creation, and that is > not what we want as stated by the [LISTEN] parameter in monkey.conf > > Correct me edsiper if I am wrong? > > > On Sun, Mar 25, 2012 at 7:11 AM, Sourabh Chandak <[email protected]> > wrote: >> >> I have already fixed that, noticed it 2 days back, will roll out with my >> next patch. Have put an extra check on the plugin side. >> >> >> On Sun, Mar 25, 2012 at 6:03 AM, Eduardo Silva <[email protected]> wrote: >>> >>> Hi Jean Paul, >>> >>> thanks for your bug report, good catch :) >>> >>> would you please log a bug into bugs.monkey-project.com ?, so we can >>> review and get it fixed. If you want to provide a patch you are >>> welcome!, feel free to stay around into our IRC channel, >>> >>> cheers, >>> >>> On Sat, Mar 24, 2012 at 5:15 PM, Jean-Paul Bonnet <[email protected]> >>> wrote: >>> > Hi everyone, >>> > >>> > There is an issue in the cheetah plugin when using the command : >>> > "config" >>> > In the case that the property "Listen" is commented in the monkey.conf >>> > file. >>> > >>> > # Listen 127.0.0.1 >>> > >>> > In this case MK_DEFAULT_LISTEN_ADDR constant in mk_config.h is set to >>> > null >>> > which is fine. >>> > But in the cheetah plugin area : file: "cmd.h" the function >>> > mk_cheetah_cmd_config() make this call: >>> > >>> > if (strcmp(mk_api->config->listen_addr, "0.0.0.0") == 0) >>> > >>> > as listen_addr is null in this case and strcmp behaviour is apparently >>> > not >>> > insured, when passing null this action result to a segfault, >>> > and an impossibility to restart the cheetah shell. >>> > >>> > Now I see 2 solutions which are setting MK_DEFAULT_LISTEN_ADDR to >>> > something >>> > else like "Localhost" or >>> > adding an other check on the plugin side to see if listen_addr is null. >>> > >>> > ------------ >>> > >>> > This project caugh my interest and I also would like to contribute, I >>> > found >>> > out that finding a small bug would be a starting point, >>> > but fixing it would be better. >>> > >>> > By the way I'm Jean-Paul a french living in Ireland and interested >>> > about >>> > learning ;) >>> > >>> > >>> > >>> > >>> > _______________________________________________ >>> > Monkey mailing list >>> > [email protected] >>> > http://lists.monkey-project.com/listinfo/monkey >>> > >>> >>> >>> >>> -- >>> Eduardo Silva >>> http://edsiper.linuxchile.cl >>> http://www.monkey-project.com >>> _______________________________________________ >>> Monkey mailing list >>> [email protected] >>> http://lists.monkey-project.com/listinfo/monkey >> >> >> >> >> -- >> Sourabh Chandak >> >> >> > > > > -- > Sourabh Chandak > > >
-- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
