Hi, here is the updated patch for MK_TRACE_BACKGROUND env variable. Thanks Ankit
On Mon, May 14, 2012 at 11:24 PM, Eduardo Silva <[email protected]> wrote: > On Mon, May 14, 2012 at 9:59 AM, Felipe Reyes <[email protected]> wrote: > > Hi, > > On Mon, May 14, 2012 at 11:14:26AM +0530, Ankit Kumar wrote: > >> Hi, > >> I am submitting the patch for this. The environment variable used is > >> BGCOLORTYPE that signifies whether the background is light or dark, and > >> changes trace colors accordingly. > > random ideas. > > vim uses the variable "background" (it's an internal variable, not from > the env), the other option is to take a look to the variable LS_COLORS, or > how 'dircolors -p' decide the colors to use > > > > Hi, > > Seems like we will add more trace options in a near future so lets > cleanup some things... I have renamed the environment variable > MONKEY_TRACE to MK_TRACE_FILTER. So following the naming conventions > we could have MK_TRACE_BACKGROUND with values "dark" or "light", being > "dark" the default of course. > > - Ankit, would you please update your patch for the naming convention ? > - Felipe, seems like a good idea bad not all linux distro set that > variable, i think that we can manage an optional value for > MK_TRACE_FILTER like "ls", a patch for that is welcome > > thanks, > > > -- > Eduardo Silva > http://edsiper.linuxchile.cl > http://www.monkey-project.com > -- Ankit Kumar Morgan Stanley | GWMG Technology Bldg. 5, Sector 30, Mindspace, Goregaon (West) Mumbai (Ex Bombay), 400 090
0001-ticket-146-MK_TRACE_BACKGROUND-env-var-based-trace-m.patch
Description: Binary data
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
