On Wed, May 23, 2012 at 12:03 PM, Davidlohr Bueso <[email protected]> wrote: > On Wed, 2012-05-23 at 14:22 +0300, Lauri Kasanen wrote: >> On Wed, 23 May 2012 13:58:25 +0300 >> Lauri Kasanen <[email protected]> wrote: >> >> > I get that. I mean that having the define in every header for every >> > function is ugly. >> > >> > With the pragma, you have two lines per header. With the attribute, you >> > have the define for every function and global variable. Much more text for >> > no benefit. >> >> We seem to have a language barrier here. Perhaps an example. >> >> Case 1, pragmas: >> >> #pragma >> >> void func1 >> void func2 >> ... >> void func50 >> >> #pragma >> >> >> That's two additions. >> >> >> Case 2, attributes: >> >> void MK_EXPORT func1 >> void MK_EXPORT func2 >> .... >> void MK_EXPORT func50 >> >> >> That's 50 additions. >> >> >> My argument is that case 2 is really ugly and case 1 much cleaner. >> The effect is the same in both cases. >> > > I see your point, however, if we just add MK_EXPORT when declaring the > functions in their corresponding header I think it's best. In my > experience this is the standard way of doing things - pragmas are rarely > used - and can immediately see it when looking at the function. Eduardo?
I think that pragmas (visibility) are a nasty-required optimization. I dont have reasons to reject the implementation. So I think that case 2 (MK_EXPORT) is the way to go. Its a minor/nice optimization which can be applied to the core plugins. regards, > >> >> - Lauri >> > > > _______________________________________________ > Monkey mailing list > [email protected] > http://lists.monkey-project.com/listinfo/monkey -- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
