Hi,

On Sat, Jul 28, 2012 at 1:14 PM, Sonny Karlsson <[email protected]> wrote:
> Hi
>
> The event_add function takes client_session and session_request
> arguments but these are not used for anything. There is no way of
> accessing these from within a plugin and they are not accessed
> anywhere else.
>
> Also if an event added with the client_session and session_request of a
> request outlives that request, we will have two pointers to freed
> memory stored which may cause trouble.
>
> Removing these will save memory and simplify the plugin api.
>

This is correct, that information is not being used. I am applying
this patch and i will add a new 'void *something' to the struct in a
later patch.

thanks for the patch!

Ed.

> --
> Sonny
>
>
> _______________________________________________
> Monkey mailing list
> [email protected]
> http://lists.monkey-project.com/listinfo/monkey
>



-- 
Eduardo Silva
http://edsiper.linuxchile.cl
http://www.monkey-project.com
_______________________________________________
Monkey mailing list
[email protected]
http://lists.monkey-project.com/listinfo/monkey

Reply via email to