[Ok, switching back to top-posting...] Whoops, I thought I already included that in my previous patchset. Oh well, I've attached it now.
Also, the package builds successfully, but there are a number of
issues raised by lintian (a commonly used tool in Debian to check
package quality):
I: monkey source: duplicate-long-description monkey monkey-dev
P: monkey source: source-contains-git-control-dir .git
W: monkey source: debhelper-but-no-misc-depends monkey-doc
W: monkey source: missing-field-in-dep5-copyright license (paragraph at line 5)
W: monkey source: missing-license-text-in-dep5-copyright gpl-2.0+
(paragrah at line 10)
W: monkey source: out-of-date-standards-version 3.9.1 (current is 3.9.4)
I: monkey-doc: extended-description-is-probably-too-short
W: monkey-doc: wrong-section-according-to-package-name monkey-doc => doc
W: monkey-doc: empty-binary-package
W: monkey-dev: empty-binary-package
X: monkey-dev: package-contains-no-arch-dependent-files
W: monkey: hardening-no-relro usr/lib/monkey/monkey-auth.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-auth.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-cgi.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-cgi.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-cheetah.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-cheetah.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-dirlisting.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-dirlisting.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-liana.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-liana.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-logger.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-logger.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-mandril.so
W: monkey: hardening-no-relro usr/lib/monkey/monkey-polarssl.so
W: monkey: hardening-no-fortify-functions usr/lib/monkey/monkey-polarssl.so
W: monkey: hardening-no-relro usr/sbin/monkey
W: monkey: hardening-no-fortify-functions usr/sbin/monkey
I: monkey: description-synopsis-might-not-be-phrased-properly
E: monkey: dir-or-file-in-var-www var/www/monkey/
E: monkey: dir-or-file-in-var-www var/www/monkey/favicon.ico
E: monkey: dir-or-file-in-var-www var/www/monkey/imgs/
E: monkey: dir-or-file-in-var-www var/www/monkey/imgs/monkey_logo.png
E: monkey: dir-or-file-in-var-www var/www/monkey/index.html
W: monkey: binary-without-manpage usr/sbin/monkey
Many of these are irrelevant if you want just working packages and
aren't immediately considering to get these packages uploaded to
Debian, but some point to real issues:
W: monkey-doc: empty-binary-package
W: monkey-dev: empty-binary-package
I'm assuming monkey-dev should install everything from src/include/ in
the source tree into /usr/include/ in the binary package, correct? And
what do you want installed into the -doc package?
W: monkey: hardening-no-{fortify-functions,relro} means that your
build system is likely disregarding the default build flags injected
into the environment by dpkg-buildflags (which include some hardening
stuff). (This would be a non-issue if monkey used a generic build
system like autotools/cmake/scons, etc., instead of a custom configure
script.)
E: monkey: dir-or-file-in-var-www is a FHS-compliance issue, but I
admit I'm not sure what the norm is, and where web server packages are
supposed to install files in instead. Might have to do a bit of
research on that, when I get some spare time.
Cheers,
Vincent
On Fri, Apr 19, 2013 at 6:38 AM, Eduardo Silva <[email protected]> wrote:
> thanks for your patches, already applied.
>
> I have just noticed that monkey.install is broken, can u fix it ?
>
> best
>
>
> On Thu, Apr 18, 2013 at 10:55 PM, Vincent Cheng <[email protected]>
> wrote:
>>
>> On Thu, Apr 18, 2013 at 7:50 AM, Eduardo Silva <[email protected]> wrote:
>> > thanks for point that.
>> >
>> > Every patch subject must be prefixed with the area that is being
>> > touched, if
>> > its for debian package it should be:
>> >
>> > Debian: something...
>> >
>> > please resubmit with the fixed subjects,
>>
>> Done. Thanks for your patience!
>>
>> Regards,
>> Vincent
>>
>> _______________________________________________
>> Monkey mailing list
>> [email protected]
>> http://lists.monkey-project.com/listinfo/monkey
>>
>
>
>
> --
> Eduardo Silva
> http://edsiper.linuxchile.cl
> http://www.monkey-project.com
0001-Debian-install-all-plugins-made-available-in-the-deb.patch
Description: Binary data
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
