thanks for the patches, comments: 1) #1 and #3 applied to master
2) In patch #2, cur mean the actual active connections, i did not understand from where you get the 500 limit, 126*4 = 504. Active connections always start from 1, if you only do 'cur > capacity' you are assuming that at some point you will have 127 to reach the condition, let me know your comments, regards, On Sun, May 19, 2013 at 11:36 AM, Zeying Xie <[email protected]> wrote: > Hi, > Here are some patches for Monkey: > [1/3] Config: remove unnecessary semicolon > [2/3] Scheduler: Fix off-by-one error > On my Linux box, according to the output of mk_details() there > are : > * * 4 threads, 126 client connections per thread, total 504* > However when deciding whether client numbers have exceeded the > max connection > numbers of a thread we have : > `cur >= config->worker_capacity` > where worker_capacity is 126 on my machine, so there can > actually have total > 500 connections. I think it is supposed to be: > `cur > config->worker_capacity` > [3/3] Cheetah: Add a function to strip leading and trailing whitespace of > input command line > I added this function to make cheetah more tolerant of user input. > > Best Regards, > swpd > > _______________________________________________ > Monkey mailing list > [email protected] > http://lists.monkey-project.com/listinfo/monkey > > -- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
