https://bugzilla.novell.com/show_bug.cgi?id=386415
User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=386415#c3 Zoltan Varga <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #3 from Zoltan Varga <[EMAIL PROTECTED]> 2008-05-03 08:23:12 MST --- Some comments about the patch: - It should contain some asserts for the stuff it does not supports (valuetypes), since users _will_ use try to use it for that despite the documentation. - + csig->params [param_count - 1] = mono_metadata_type_dup (image->mempool, + &mono_defaults.exception_class->byval_arg); no need for the type_dup, &mono_defaults.exception_class->byval_arg is enough. - the tests look a bit ugly, but at least we now have some automated tests for parts of the embedding api :) Otherwise, the patch looks good. Thanks! -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs
