http://bugzilla.novell.com/show_bug.cgi?id=605688
http://bugzilla.novell.com/show_bug.cgi?id=605688#c0 Summary: ReviewLinqMethodRule is never call on .Net 3.5 Classification: Mono Product: Mono: Tools Version: unspecified Platform: Other OS/Version: Windows 7 Status: NEW Severity: Normal Priority: P5 - None Component: Gendarme AssignedTo: mono-bugs@lists.ximian.com ReportedBy: avandecr...@sopragroup.com QAContact: mono-bugs@lists.ximian.com Found By: --- Blocker: --- Created an attachment (id=362126) --> (http://bugzilla.novell.com/attachment.cgi?id=362126) Patch User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 No detection by this rule even if there is bad code Reproducible: Always Steps to Reproduce: 1. Write bad linq code (for exemple myEnumerable.Count() == 0) :p 2. Compile in .Net 3.5 3. Run the rule on the generated assembly Actual Results: No defect found Expected Results: Defect The provided patch fix the performance improvement which avoid to analyze assemblies compiled in .Net 2. The test was : TargetRuntime > Net_2_0 but .Net 3.5 actually run under runtime 2. The test now is : TargetRuntime >= Net_2_0 and the assembly must reference System.Core. There is maybe a better test to do. And it is probably a good idea to put it in AssemblyRocks. The patch also add some improvements and associated test cases. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. _______________________________________________ mono-bugs maillist - mono-bugs@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-bugs