Moving Locale.cs and MonoTODO.cs into a common area will break standalone VS.Net projects. Several of the MWF contributors as well as Jordi and I use those. I would like to keep MWF self-contained.
Peter -----Original Message----- From: "Ben Maurer" <[EMAIL PROTECTED]> To: "Kornél Pál" <[EMAIL PROTECTED]> Cc: <[email protected]> Date: Tuesday, 14 June, 2005 18:50 Subject: Re: [Mono-devel-list] [PATCH] Reworked unified Locale classes >On Mon, 2005-06-13 at 13:14 +0200, Kornél Pál wrote: >> >> What about a pacth that adds a common Locale.cs copy, modifies sources >> >> files >> >> and removes unused Locale.cs files? >> > ... >> > That's exactly what I suggested :-). I think that is the first step. >> >> This patch has to be easy to review. >> I added the common Locale.cs and I modified the .sources files in all of >> the >> assemblies except in corlib because it has to have it's own modified >> version. >> I did not remove any files yet so the diff file is much short. >> >> By the way does corlib have any conditional compilation constants (for >> example INSIDE_CORLIB) defined everytime it is compiled? If it has the >> same >> Locale.cs could be used with conditional compilation that could make code >> maintenance easier. > >INSIDE_CORLIB is defined :-). You could always look at the commands make >runs... > >> Please review this patch and approve it if you think so. Otherwise please >> explain me what should I modify. > >I committed something similar to this. > >-- Ben > >_______________________________________________ >Mono-devel-list mailing list >[email protected] >http://lists.ximian.com/mailman/listinfo/mono-devel-list > > _______________________________________________ Mono-devel-list mailing list [email protected] http://lists.ximian.com/mailman/listinfo/mono-devel-list
