On 6/20/05, Ben Maurer <[EMAIL PROTECTED]> wrote: > On Mon, 2005-06-20 at 00:44 -0600, David Waite wrote: > > Included in this patch are implementations of Collection<T> and > > ReadOnlyCollection<T>. KeyedCollection I left alone. > > > > 2005-06-19 David Waite <[EMAIL PROTECTED]> > > > > * Collection.cs ReadonlyCollection.cs: Implement all methods > > _______________________________________________ > > > > > - throw new NotImplementedException (); > > + if (list == null) > > + throw new ArgumentNullException("list"); > > + this.list = list; > > + ICollection l = list as ICollection; > > + syncRoot = (l != null) ? l.SyncRoot : new object(); > > } > > Is the syncroot behavior exactly what msft does? Do you have tests? > (ditto for readonly version).
I'll refactor my behavioral exploration code against b2 into a test before committing. I have no other tests currently. I'm starting to wonder if creating a set of generic test fixtures for list may be appropriate, since there is a lot of reuse potential across the different 'list' implementations, and may be a case later to test against different contained types. - David Waite _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list