There are two for loops in the test case you are talking about:

+ for (char c=Char.MinValue; c<128; c++)

+ for (char c=(char)128; c < Char.MaxValue; c++) {

But I think this check is too lame:
+ string s = c.ToString();
+ Assert.IsTrue (s !=
System.Web.HttpUtility.UrlEncode(s),

I think it's better to do equality test with expected value if we need this
at all.

Kornél

----- Original Message -----
From: "Matthijs ter Woord" <[EMAIL PROTECTED]>
To: "Ben Maurer" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>;
<Mono-devel-list@lists.ximian.com>
Sent: Tuesday, January 03, 2006 6:51 PM
Subject: Re: [Mono-dev] UrlEncode difference in dotnet and mono


Just use Char.MaxValue instead of 128




----- Original Message -----
From: "Ben Maurer" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Cc: <Mono-devel-list@lists.ximian.com>; <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
Sent: Tuesday, January 03, 2006 6:41 PM
Subject: RE: [Mono-dev] UrlEncode difference in dotnet and mono



> + for (char c=Char.MinValue; c<128; c++)

chars are from 0 to 2^16-1

-- Ben


_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Reply via email to