On Thu, 2006-02-16 at 20:51 -0500, Chris Toshok wrote: > This patch looks okay, except for the switch from 'df != ""' to > 'df.Length != 0'. I'd prefer the former (and in general I'd rather > adapt whatever my thoughts are on the matter to what the original author > wrote.)
`df != ""' may make more sense than `df.Length != 0', but the latter is much faster than the former, and FxCop always suggests the latter over the former. If you ever intend on using FxCop or similar tools regularly, you might consider following the guidelines to reduce the number of warnings generated. :-) - Jon _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
