please don't commit this until I've reviewed it. Chris
On Tue, 2006-04-11 at 00:31 -0700, Andrew Skiba wrote: > As no one replied, I will commit the patch. > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf > > Of Andrew Skiba > > Sent: Sunday, April 09, 2006 16:41 > > To: [EMAIL PROTECTED] > > Cc: Mono-devel-list@lists.ximian.com > > Subject: [Mono-dev] TemplateControlCompiler.cs > > > > Hi, Chris. > > > > At revision 56619 you introduced the following code at > > TemplateControlCompiler.cs:176 > > > > if (builder is RootBuilder) { > > typeString = parser.ClassName; > > } > > > > In my flow, parser.ClassName == "Default_aspx", which is > > unresolved, but parser.PartialClassName has the correct value > > of "_Default". > > > > At BaseCompiler.Init there is a similar code: > > > > if (parser.IsPartial) { > > ... > > mainClass = new CodeTypeDeclaration (parser.PartialClassName); > > ... > > } else { > > ... > > mainClass = new CodeTypeDeclaration (parser.ClassName); } > > > > So, what do you think of the following patch? > > > > Thank you. > > Andrew. > > > > Index: TemplateControlCompiler.cs > > =================================================================== > > --- TemplateControlCompiler.cs (revision 59261) > > +++ TemplateControlCompiler.cs (working copy) > > @@ -174,7 +174,10 @@ > > if (childrenAsProperties || > > builder.ControlType == null) { > > string typeString; > > if (builder is RootBuilder) { > > - typeString = parser.ClassName; > > + if (parser.IsPartial) > > + typeString = > > parser.PartialClassName; > > + else > > + typeString = > > parser.ClassName; > > } > > else { > > if (builder.ControlType != null > > && builder.isProperty && > > _______________________________________________ > > Mono-devel-list mailing list > > Mono-devel-list@lists.ximian.com > > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
