I'd like to see the test used for this as well. At first blush the theme change looks ok, but I really don't like the idea of adding the ApplyTheme behavior to OnInit. Unless, of course, this is what actually happens in MS's implementation.
Also, the master page change doesn't seem necessary to me, in the scope of the greater change. The controls will have their OnInit methods's called properly when they're added to the already Init'ed controls. Chris On Sun, 2006-04-23 at 09:33 -0700, Andrew Skiba wrote: > Please ignore the previous patch, review the new patch instead. Sorry > for the inconvenience. > > The previous patch did not handle the situation when StyleSheetTheme > should affect a control created by template (as ImageButton inside > LoginView). > > To find out the correct flow, I subclassed an ImageButton in dotnet, and > watched the order in which the following methods were called: > > EnsureChildControls, OnPreRender, OnLoad, OnInit, ApplyStyleSheetSkin, > set_ImageUrl > > In current mono implementation theme is applied for all the control > hierarchy before applying the master page. But at this stage many > controls still don't exist. My previous patch solved problem with master > page, but not with contols created during PreRerderRecursiveInternal. > This patch solves the problem and removes code duplication for > recursion. > > If no one objects, I will commit. > > Thank you. > Andrew. > > > -----Original Message----- > > From: [EMAIL PROTECTED] > > [mailto:[EMAIL PROTECTED] On Behalf > > Of Andrew Skiba > > Sent: Sunday, April 23, 2006 11:46 > > To: mono-devel-list@lists.ximian.com > > Subject: [Mono-dev] System.Web.UI.Page patch > > > > The attached patch fixes the flow for themes combined with > > master pages. > > If no one objects, I will commit. > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
