Hello David,
On Mon, 2008-06-16 at 12:56 -0400, David Wolinsky wrote:
> Many apologies for the mistakes! I appreciate the thoroughness and
> have
> hopefully not looked over any issues in this patch.
Everything was committed (r106667-9) except for this...
> mono-1.9.1/mcs/class/Mono.Security/Mono.Security.X509/ChangeLog
> 2008-06-16 12:47:03.000000000 -0400
> @@ -1,3 +1,8 @@
> +2008-06-13 David Wolinsky <[EMAIL PROTECTED]>
> +
> + * X509CertificateBuilder.cs: Extensions is now writable so that it
> + can be added unto during run time.
> +
> 2007-05-09 Sebastien Pouliot <[EMAIL PROTECTED]>
>
> * PKCS12.cs: Adds SecretBag support. Patch by Jay Miller.
> diff -urN
> mono-1.9.1-old/mcs/class/Mono.Security/Mono.Security.X509/X509CertificateBuilder.cs
>
> mono-1.9.1/mcs/class/Mono.Security/Mono.Security.X509/X509CertificateBuilder.cs
> ---
> mono-1.9.1-old/mcs/class/Mono.Security/Mono.Security.X509/X509CertificateBuilder.cs
> 2007-11-08 17:34:18.000000000 -0500
> +++
> mono-1.9.1/mcs/class/Mono.Security/Mono.Security.X509/X509CertificateBuilder.cs
> 2008-06-16 12:45:25.000000000 -0400
> @@ -136,6 +136,7 @@
>
> public X509ExtensionCollection Extensions {
> get { return extensions; }
> + set { extensions = value; }
> }
since there's no need to set the collection (to a new one) since the
existing collection can be used (and cleared if needed).
I also renamed Mono.Security.X509.Extensions/SubjectAltNameTest.cs to
Mono.Security.X509.Extensions/SubjectAltNameExtensionTest.cs to be
consistent with the class name and the other filenames.
Thanks a lot for the patch!
Sebastien
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
