Hello Mark,
On Tue, 2009-03-17 at 10:58 +0100, Mark Probst wrote:
> Hi Sebastien,
>
> Apart from what Rodrigo said I only two tiny issues with the patch.
> First it would be nice if you could split it up between the part that
> handles field access, the part that handles wrappers and the part that
> handles the image stuff.
Split the patch ? no problem.
> And then there's this:
>
> + for (i = 0; i < 11; i++) {
> + if (strstr (image->name, platform_code_assemblies[i]))
> + return TRUE;
> + }
>
> Please don't hard-code the number of elements in the array :-)
Like I said to Rodrigo later the "platform check" part was not complete
and is already quite different (to match the other email thread) and
this is not hard coded anymore ;-)
Now one thing remains unanswered, could you share your lights on:
> static gboolean
> method_is_safe (MonoMethod *method)
> {
> - /*
> + /* FIXME: looks somewhat incomplete
>
> I think this is just dead code used during the initial
development of
> core-clr security.
yes, the comment was to trigger a definitive answer of that :)
Thanks!
Sebastien
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
