Committed to trunk. r136836.
On Sun, Jun 7, 2009 at 11:50 PM, Sylvain Dupont<dupo...@gmail.com> wrote: > Bill, > > Thanks for the feedback. I attach an updated patch that addresses the issues > you found. Here are the details: > > 1) Failing cominterop.exe tests: > Sorry for not catching that. There was a flaw in my initial testing > approach. Basically I only tested with assemblies compiled with the > Microsoft compiler and never tested assemblies compiled with the mono mcs > compiler. Due to a bug in the mcs compiler the SafeArraySubType marshal > attribute option was not properly generated. It was being dropped. I fixed > that issue in the attached patch by making changes to two files: > reflection.c and CustomAttributeBuilder.cs. > > 2) Tab problems in cominterop.cs: > I fixed the issues you noticed in cominterop.cs. I also did one pass on all > the files to clean-up tabs, white spaces, formatting, etc. > > 3) Changelog entries: > I updated the changelogs in the 3 directories where I made changes. > > Thanks, > Sylvain > > On Wed, Jun 3, 2009 at 5:02 PM, Bill Holmes <billholme...@gmail.com> wrote: >> >> Sorry I should have mentioned that I tested this on Win32 and Winx64. >> >> On Wed, Jun 3, 2009 at 5:00 PM, Bill Holmes <billholme...@gmail.com> >> wrote: >> > I tested this patch out and the cominterop.exe test does not work. I >> > get a return value of 62. >> > >> > Second I noticed some tab problems with your formatting in >> > cominterop.cs. >> > >> > Finally It makes it easier for me to commit a patch if you include >> > ChangeLog entirs. >> > >> > thanks >> > -bill >> > >> > On Sun, May 17, 2009 at 8:43 PM, Sylvain Dupont <dupo...@gmail.com> >> > wrote: >> >> Hi, >> >> >> >> The patch attached adds support for marshalling out parameters of type >> >> SAFEARRAY[VARIANT]. In addition to the tests included in the patch, I >> >> have >> >> also tested this successfully against other COM components, both on >> >> Windows >> >> and Linux (using Mainwin and with the MONO_COM environment variable set >> >> to >> >> MS). >> >> >> >> Contributed under MIT/X11 license. >> >> >> >> Thanks, >> >> Sylvain >> >> >> >> _______________________________________________ >> >> Mono-devel-list mailing list >> >> Mono-devel-list@lists.ximian.com >> >> http://lists.ximian.com/mailman/listinfo/mono-devel-list >> >> >> >> >> > > > _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list