They are all fixed in svn trunk, except the case that casts to UIntXX expect FormatException instead of OverflowException, which I believe is not possible due to NET's call to internal members in corlib (commented as r149388).
Man, I'm exhausted to fix those extensive tests ;-) Thanks again for the great work! Atsushi Eno On 2010/01/12 9:00, Atsushi Eno wrote: > Oh, those are nice tests. Thanks for writing them :-) > > I'll examine the failing tests and will fix identified bugs. > > Atsushi Eno > > Tiaan Geldenhuys wrote: > >> Thanks, Atsushi. Fair enough, see the attachment for the enhanced tests >> that you can also apply to the trunk; the test for my earlier patch is >> simply whether the enhanced code can compile under Mono. However, once >> compiled and running, the extra tests also highlight numerous discrepancies >> between the behavior of Mono and MS .NET when using the casting operators of >> XElement (all the new CastXxx tests pass under .NET, while many fail under >> Mono). It seems that the underlying XmlConvert class may cause some of the >> problems. Since I provided the welcomed tests, would you mind logging these >> bugs or fixing them? ;-) >> >> Regards, >> Tiaan. >> >> >> >> -----Original Message----- >> From: Atsushi Eno [mailto:atsushi...@veritas-vos-liberabit.com] >> Sent: 09 January 2010 3:51 AM >> To: Tiaan Geldenhuys >> Cc: mono-devel-list@lists.ximian.com >> Subject: Re: [Mono-dev] [PATCH] Add missing DateTimeOffset operators to >> XElement >> >> Hello, >> >> Thanks, I'm going to apply the patch. (Patches with tests are more >> welcomed ;-) >> >> Atsushi Eno >> >> On 2010/01/09 13:04, Tiaan Geldenhuys wrote: >> >> >>> This patch adds two of the newer DateTimeOffset operators that are >>> still missing on the System.Xml.Linq.XElement class. >>> >>> Please commit. >>> >>> >>> _______________________________________________ >>> Mono-devel-list mailing list >>> Mono-devel-list@lists.ximian.com >>> http://lists.ximian.com/mailman/listinfo/mono-devel-list >>> >>> >>> > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > > _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
