Hi again, As for the properties test case, never mind. I happened to get one at hand (as my reply on DestinationUnreachable implies).
Atsushi Eno On 2010/03/23 21:49, Atsushi Eno wrote: > Hello, > > Thanks for the patch. They are looking like a great set of attempts > for cool bugfixes :) However there is a lot of other changes that your > description cannot explain. So, please first split the changes into > further smaller patches for each purpose, and give explanation for > each change. For example, > > - // FIXME: this should not be required, but it somehow saves some > failures wrt concurrent calls. > - Thread.Sleep (100); > > This kind of change should not be made without explanation. (you > aren't really sure about why it exists, right?) > > As for ChannelListenerBase.Properties, I'd rather make the changes > much smaller like the attached change. Isn't it enough? There's no > test case that I can verify your (and-my) changes. > > Atsushi Eno > > On 2010/03/23 20:28, Matt Dargavel wrote: >> >> The included patches fix the following: >> >> multithreaded_fixes.patch: ObjectDisposedException, >> InvalidOperationException("Another async TryReceiveRequest operation >> is in progress") and other multithreaded timing fixes. Also includes >> change to make GET ?wsdl case insensitive. >> >> properties_handling.patch: MetadataPublishingInfo not available in >> TransactionChannelListener’s inner_listener. I created a new >> RetrieveProperty function as overriding GetProperty<T> didn’t work- >> the ChannelListenerBase implementation was still called. Perhaps >> there’s a bug with generic function overrides or maybe I’ve done >> something silly there? >> >> properties_and_wsdl.patch: patch for ServiceMetadataExtension.cs that >> goes with the properties changes and the ?wsdl change. >> >> Let me know if you have any questions. :-) >> >> Matt. >> > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list