On 04/07/10 Phil Garcia wrote: > Since we are implementing everything in .NET/C# we don?t need InternalCalls > to call external API bindings. In fact, the external declarations in the > source code get into the way. So we have moved the InternalCalls method > declarations into separate partial class files (for example, > String.Internal.cs). This patch allows us to compile Mono class libraries > without referencing those external methods declarations and substitute own > managed versions.
I don't think that shuffling around the code like that is acceptable for us. A change that could be included would be to surround the icalls with a #if check and then you compile with that define. I suggest something like NO_ICALLS. > We had updated the Object class too, but it caused a single failed test so > we have excluded it from here. The test failed due to a change in the order > of the Object class methods. We are not sure if this is just a paranoia > check (but kumpera on IRC said "tons of user code can depend on it"). > Otherwise, all the other tests passed. We checked the new mscorlib from .NET > 4.0 through ildasm and Mono doesn't follow the same method ordering for > Object. Is the ordering of methods for the Object class really important for > Mono? If you pointed out the name of the test we could fix it to not depend on the order if it's really a bug in the test. lupus -- ----------------------------------------------------------------- lu...@debian.org debian/rules lu...@ximian.com Monkeys do it better _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list