Hey Rolf, Doesn't this change affect on all of those who build mono --with-moonlight=yes, even if they after all use the runtime as non-moonlight profile with this buffering? IMO, if the change is not harmful, this should be enabled regardless of the profile. If it in fact is, then there should be another approach to be taken e.g. run-time platform detection, or build different object for libmono and libmono-moon.
Oh, and it doesn't build on Windows. I disabled it so far. Atsushi Eno -------- Original Message -------- Subject: [Mono-patches] r160111 - trunk/mono/mono/mini Date: Fri, 9 Jul 2010 05:44:32 -0400 (EDT) From: Rolf Bjarne Kvinge (rolfkvi...@ya.com) <mono-patches-l...@lists.ximian.com> To: mono-patc...@lists.ximian.com, ximian.monol...@gmail.com, mono-svn-patches-garchive-20...@googlegroups.com Author: rolf Date: 2010-07-09 05:44:32 -0400 (Fri, 09 Jul 2010) New Revision: 160111 Modified: trunk/mono/mono/mini/ChangeLog trunk/mono/mono/mini/driver.c Log: 2010-07-09 Rolf Bjarne Kvinge<rkvi...@novell.com> * driver.c: Moonlight: Force line buffering for stdout. Modified: trunk/mono/mono/mini/ChangeLog =================================================================== --- trunk/mono/mono/mini/ChangeLog 2010-07-09 09:40:59 UTC (rev 160110) +++ trunk/mono/mono/mini/ChangeLog 2010-07-09 09:44:32 UTC (rev 160111) @@ -1,3 +1,7 @@ +2010-07-09 Rolf Bjarne Kvinge<rkvi...@novell.com> + + * driver.c: Moonlight: Force line buffering for stdout. + 2010-07-09 Zoltan Varga<var...@gmail.com> * mini-llvm.c (emit_load): Revert the last changes, the load/store intrinsics Modified: trunk/mono/mono/mini/driver.c =================================================================== --- trunk/mono/mono/mini/driver.c 2010-07-09 09:40:59 UTC (rev 160110) +++ trunk/mono/mono/mini/driver.c 2010-07-09 09:44:32 UTC (rev 160111) @@ -1316,6 +1316,13 @@ int test_jit_info_table = FALSE; #endif +#ifdef MOONLIGHT + /* stdout defaults to block buffering if it's not writing to a terminal, which + * happens with our test harness: we redirect stdout to capture it. Force line + * buffering in all cases. */ + setlinebuf (stdout); +#endif + setlocale (LC_ALL, ""); vm_config = getenv ("MONO_VM_CONFIG"); _______________________________________________ Mono-patches maillist - mono-patc...@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-patches _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list