On 18/10/13 14:58, Jonathan Pryor wrote:
On Oct 16, 2013, at 10:00 AM, Alexander Köplinger <alex.koeplin...@outlook.com>
wrote:
Wouldn’t it make sense to remove the #if NET_2_0 checks in the codebase as
those are now unnecessary (every profile is now 2.0 or later)?
Or are they actually required for something? If not, I’d provide a pull request
to clean up those checks.
They are not required, but removing them would add extra "commit noise", which
isn't necessary.
Current "policy" (as it were) is to remove "nearby" `#if`s when modifying
nearby code, so things can be improved in an ongoing basis without littering commit history.
WRT git-blame, changing whitespace in existing code clutters commit
history, but removing code doesn't.
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
