I created PR 1672 for this. It’s a really minor fix - seems like it was an oversight in the prior PR. Please review and comment.
On Apr 1, 2015, at 1:04 AM, David Curylo <cury...@asme.org> wrote: > PR #1257 seems to be causing a new regression for me since upgrading from > 3.8.0 to 3.12.1 (this PR was merged before 3.10.0). Xml serialization from > SOAP responses where {V}Specified values would need to be set are no longer > reliably set. The only way to get them to work reliably seems to be if I add > ShouldSerialize{V} methods. It seems to go back to this commit. > > https://github.com/mono/mono/commit/52cdea5c0ad5e4ee8ee218b0f90522645ec3ad8a > > It seems that in some cases, the {V}Specified boolean isn’t getting set. > It’s sporadic for me when this issue actually occurs, so I don’t yet have an > isolated test case, but looking through the code, this logic doesn’t seem > right to me: > > public bool IsValueSpecifiedSettable () { > … > return ((PropertyInfo) _specifiedMember).CanWrite; > … > return ((FieldInfo) _specifiedMember).IsInitOnly; > … > } > > https://github.com/mono/mono/commit/52cdea5c0ad5e4ee8ee218b0f90522645ec3ad8a#diff-3c49e354661f4bb712bf89209bbb85b4R224 > > If it’s a writable property we return true, but if it's a read-only field, we > also return true? I think we’d want to return false if it were a read-only > field and since mine (and probably everyone’s) {V}Specified fields are > generated public boolean fields, then this results in a false so specified > doesn’t get set. I’m guessing there is some other race going on because it > is set sometimes, not others. Anyone else having issues with {V}Specified > fields since this fix?
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list