I've gone through and changed interface_id to a guint32, along with max_interface_id, leaving interface_count (I didn't see the need for it to be increased).
I've forked the repo and have it over at https://github.com/tastywheattasteslikechicken/mono/commit/6e7f1d94eb07822fb7bf5687b67df5076f969818 Are there any other considerations or things that may be missed? On Wed, Jan 6, 2016 at 12:51 AM, Jamie Venning < jamie_venn...@technologyonecorp.com> wrote: > Yeah, what I'm chasing are the best ways to cause failures without this > assertion -- that way as I go through and fix things I can be more > confident that things haven't been missed. > > On Tue, Jan 5, 2016 at 11:45 PM, Alexander Köplinger < > alexander.koeplin...@xamarin.com> wrote: > >> I don't think it's as easy as removing the assert. >> >> For one, the interface ID returned by mono_get_unique_iid() is stored as >> a guint16 ( >> https://github.com/mono/mono/blob/36c7332104eb5250a93079ae77c2e0dbf12c6c9a/mono/metadata/class-internals.h#L344) >> which means you only have 0-65,535 values there. I'm not familiar enough >> with the runtime codebase to say which other problems you'll run into if >> you try to fix this. >> >> - Alex >> >> 2016-01-05 8:38 GMT+01:00 Jamie Venning < >> jamie_venn...@technologyonecorp.com>: >> >>> Good Morning. >>> >>> Bug 10784 ( >>> https://bugzilla.xamarin.com/show_bug.cgi?format=multiple&id=10784) is >>> a major blocker for me, and a big obstacle for larger applications moving >>> from .NET to Mono. Because I need this fixed, I am prepared to fix it >>> myself. >>> >>> I'm wondering if anyone knowledgeable in this area could answer these >>> few, short questions just to confirm a few things. >>> >>> Removing the offending assertion from class.c, and running generated >>> test cases that previously triggered it, I did not notice any incorrect >>> behaviour in terms of reflection, the 'is' operator failing, or the wrong >>> implementation of functions being used. Is there anywhere that I should be >>> looking in particular or any particular type of tests I can use to expose >>> an underlying fault that removing this assertion causes? >>> >>> Is it possible that this assertion is vestigial or unnecessary? >>> >>> -- >>> >>> James Venning >>> Research & Development - Ci2 - Product >>> Phone: +61 7 3167 7300 | Fax: +61 7 3167 7301 Address: Level 11, >>> TechnologyOne HQ, 540 Wickham Street, Fortitude Valley QLD 4006 (PO Box 96 >>> Fortitude Valley QLD 4006) Email: jamie_venn...@technologyonecorp.com >>> Web: TechnologyOneCorp.com <http://www.technologyonecorp.com/> >>> >>> <http://www.technologyonecorp.com/> >>> >>> Financials | Human Resource & Payroll | Supply Chain | Corporate >>> Performance Management | Property & Rating | Student Management | Asset >>> Management | Enterprise Content Management | Customer Relationship >>> Management | Consulting Services >>> >>> *TechnologyOne (ASX:TNE) is Australia's largest publicly listed software >>> company, with offices across six countries including each state and >>> territory of Australia, as well as New Zealand, the South Pacific, Asia and >>> the United Kingdom. For 25 years, we have been providing powerful and >>> deeply integrated enterprise software solutions that are used every day by >>> more than 1000 leading corporations, government departments and statutory >>> authorities.* >>> >>> TechnologyOne accepts no liability for any damage caused by this email >>> or its attachments. The information in this email is only for the intended >>> recipient and may contain confidential and/or privileged material. If you >>> received this in error, please kindly notify the sender and delete this >>> email and any attachments from your system. Opinions, conclusions and other >>> information in this message that do not relate to the official business of >>> the company shall be understood as neither given nor endorsed by it. If you >>> believe that you have been spammed please email >>> stop_s...@technologyonecorp.com <stop_s...@technologyonecorp.com>. >>> >>> _______________________________________________ >>> Mono-devel-list mailing list >>> Mono-devel-list@lists.ximian.com >>> http://lists.ximian.com/mailman/listinfo/mono-devel-list >>> >>> >> > > > -- > > Jamie Venning > Research & Development - Ci2 - Product > Phone: +61 7 3167 7300 | Fax: +61 7 3167 7301 Address: Level 11, > TechnologyOne HQ, 540 Wickham Street, Fortitude Valley QLD 4006 (PO Box 96 > Fortitude Valley QLD 4006) Email: jamie_venn...@technologyonecorp.com > Web: TechnologyOneCorp.com <http://www.technologyonecorp.com/> > > <http://www.technologyonecorp.com/> > > Financials | Human Resource & Payroll | Supply Chain | Corporate > Performance Management | Property & Rating | Student Management | Asset > Management | Enterprise Content Management | Customer Relationship > Management | Consulting Services > > *TechnologyOne (ASX:TNE) is Australia's largest publicly listed software > company, with offices across six countries including each state and > territory of Australia, as well as New Zealand, the South Pacific, Asia and > the United Kingdom. For 25 years, we have been providing powerful and > deeply integrated enterprise software solutions that are used every day by > more than 1000 leading corporations, government departments and statutory > authorities.* > > TechnologyOne accepts no liability for any damage caused by this email or > its attachments. The information in this email is only for the intended > recipient and may contain confidential and/or privileged material. If you > received this in error, please kindly notify the sender and delete this > email and any attachments from your system. Opinions, conclusions and other > information in this message that do not relate to the official business of > the company shall be understood as neither given nor endorsed by it. If you > believe that you have been spammed please email > stop_s...@technologyonecorp.com <stop_s...@technologyonecorp.com>. > -- Jamie Venning Intern Developer | Research & Development - Ci2 - Product Phone: +61 7 3167 7300 | Fax: +61 7 3167 7301 Address: Level 11, TechnologyOne HQ, 540 Wickham Street, Fortitude Valley QLD 4006 (PO Box 96 Fortitude Valley QLD 4006) Email: jamie_venn...@technologyonecorp.com Web: TechnologyOneCorp.com <http://www.technologyonecorp.com/> <http://www.technologyonecorp.com/> Financials | Human Resource & Payroll | Supply Chain | Corporate Performance Management | Property & Rating | Student Management | Asset Management | Enterprise Content Management | Customer Relationship Management | Consulting Services *TechnologyOne (ASX:TNE) is Australia's largest publicly listed software company, with offices across six countries including each state and territory of Australia, as well as New Zealand, the South Pacific, Asia and the United Kingdom. For 25 years, we have been providing powerful and deeply integrated enterprise software solutions that are used every day by more than 1000 leading corporations, government departments and statutory authorities.* TechnologyOne accepts no liability for any damage caused by this email or its attachments. The information in this email is only for the intended recipient and may contain confidential and/or privileged material. If you received this in error, please kindly notify the sender and delete this email and any attachments from your system. Opinions, conclusions and other information in this message that do not relate to the official business of the company shall be understood as neither given nor endorsed by it. If you believe that you have been spammed please email stop_s...@technologyonecorp.com <stop_s...@technologyonecorp.com>.
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
