Author: lluis
Date: 2006-08-29 07:59:22 -0400 (Tue, 29 Aug 2006)
New Revision: 64508
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/ChangeLog
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.mdp
Log:
2006-08-29 Lluis Sanchez Gual <[EMAIL PROTECTED]>
* MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs: Make the toolbar smaller
and add some spacing.
* MonoDevelop.Ide.mdp: Removed unused file.
* MonoDevelop.Ide.Gui/Document.cs: Unsubscribe ActiveViewContentChanged
event when the window is closed.
* MonoDevelop.Ide.Gui/Workbench.cs: Fixed error message.
* MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs: Added some missing
Destroys().
* MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs: Unsubscribe events to avoid
memory leaks.
Modified: trunk/monodevelop/Core/src/MonoDevelop.Ide/ChangeLog
===================================================================
--- trunk/monodevelop/Core/src/MonoDevelop.Ide/ChangeLog 2006-08-29
11:36:36 UTC (rev 64507)
+++ trunk/monodevelop/Core/src/MonoDevelop.Ide/ChangeLog 2006-08-29
11:59:22 UTC (rev 64508)
@@ -1,3 +1,15 @@
+2006-08-29 Lluis Sanchez Gual <[EMAIL PROTECTED]>
+
+ * MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs: Make the toolbar smaller
+ and add some spacing.
+ * MonoDevelop.Ide.mdp: Removed unused file.
+ * MonoDevelop.Ide.Gui/Document.cs: Unsubscribe ActiveViewContentChanged
+ event when the window is closed.
+ * MonoDevelop.Ide.Gui/Workbench.cs: Fixed error message.
+ * MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs: Added some missing
Destroys().
+ * MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs: Unsubscribe events to avoid
+ memory leaks.
+
2006-08-22 Lluis Sanchez Gual <[EMAIL PROTECTED]>
* MonoDevelop.Ide.Gui.Pads.ClassPad/NamespaceNodeBuilder.cs: Fixed
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs
===================================================================
--- trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs
2006-08-29 11:36:36 UTC (rev 64507)
+++ trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Document.cs
2006-08-29 11:59:22 UTC (rev 64508)
@@ -58,8 +58,8 @@
internal Document (IWorkbenchWindow window)
{
this.window = window;
- window.Closed += new EventHandler (OnClosed);
- window.ActiveViewContentChanged += delegate {
OnViewChanged (EventArgs.Empty); };
+ window.Closed += OnClosed;
+ window.ActiveViewContentChanged +=
OnActiveViewContentChanged;
}
public string FileName {
@@ -244,9 +244,16 @@
void OnClosed (object s, EventArgs a)
{
+ window.Closed -= OnClosed;
+ window.ActiveViewContentChanged -=
OnActiveViewContentChanged;
OnClosed (a);
}
+ void OnActiveViewContentChanged (object s, EventArgs args)
+ {
+ OnViewChanged (args);
+ }
+
protected virtual void OnClosed (EventArgs args)
{
if (Closed != null)
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs
===================================================================
---
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs
2006-08-29 11:36:36 UTC (rev 64507)
+++
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceLayout.cs
2006-08-29 11:59:22 UTC (rev 64508)
@@ -580,14 +580,16 @@
public void CloseWindowEvent(object sender, EventArgs e)
{
- // FIXME: GTKize
+ SdiWorkspaceWindow f = (SdiWorkspaceWindow)sender;
+
+ // Unsubscribe events to avoid memory leaks
+ f.TabLabel.Button.Clicked -= new EventHandler
(closeClicked);
+ f.TabLabel.Button.StateChanged -= new
StateChangedHandler (stateChanged);
- SdiWorkspaceWindow f = (SdiWorkspaceWindow)sender;
if (f.ViewContent != null) {
((IWorkbench)wbWindow).CloseContent(f.ViewContent);
ActiveMdiChanged(this, null);
}
-
}
public IWorkbenchWindow ShowView(IViewContent content)
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs
===================================================================
---
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs
2006-08-29 11:36:36 UTC (rev 64507)
+++
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/SdiWorkspaceWindow.cs
2006-08-29 11:59:22 UTC (rev 64508)
@@ -77,6 +77,10 @@
tabPage = value;
}
}
+
+ internal TabLabel TabLabel {
+ get { return tabLabel; }
+ }
public bool ShowNotification {
get {
@@ -238,6 +242,7 @@
}
this.Remove (this.Child);
content.Dispose ();
+ tabLabel.Dispose ();
OnClosed (null);
@@ -246,6 +251,8 @@
this.tabControl = null;
this.tabLabel = null;
this.tabPage = null;
+ Dispose ();
+ Destroy ();
}
public void AttachSecondaryViewContent(ISecondaryViewContent
subViewContent)
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs
===================================================================
--- trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs
2006-08-29 11:36:36 UTC (rev 64507)
+++ trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui/Workbench.cs
2006-08-29 11:59:22 UTC (rev 64508)
@@ -622,7 +622,7 @@
else
newContent.Load (fileName);
} catch (Exception ex) {
- IdeApp.Services.MessageService.ShowError (ex,
GettextCatalog.GetString ("The file '{0}' could not be opened."));
+ IdeApp.Services.MessageService.ShowError (ex,
GettextCatalog.GetString ("The file '{0}' could not be opened.", fileName));
return;
}
Modified:
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs
===================================================================
---
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs
2006-08-29 11:36:36 UTC (rev 64507)
+++
trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs
2006-08-29 11:59:22 UTC (rev 64508)
@@ -70,7 +70,7 @@
control = new VBox ();
Toolbar toolbar = new Toolbar ();
- toolbar.IconSize = IconSize.SmallToolbar;
+ toolbar.IconSize = IconSize.Menu;
control.PackStart (toolbar, false, false, 0);
errorBtn = new ToggleToolButton ();
@@ -382,17 +382,17 @@
void UpdateErrorsNum ()
{
- errorBtn.Label =
string.Format(GettextCatalog.GetPluralString("{0} Error", "{0} Errors",
errors), errors);
+ errorBtn.Label = " " +
string.Format(GettextCatalog.GetPluralString("{0} Error", "{0} Errors",
errors), errors);
}
void UpdateWarningsNum ()
{
- warnBtn.Label =
string.Format(GettextCatalog.GetPluralString("{0} Warning", "{0} Warnings",
warns), warns);
+ warnBtn.Label = " " +
string.Format(GettextCatalog.GetPluralString("{0} Warning", "{0} Warnings",
warns), warns);
}
void UpdateMessagesNum ()
{
- msgBtn.Label =
string.Format(GettextCatalog.GetPluralString("{0} Message", "{0} Messages",
msgs), msgs);
+ msgBtn.Label = " " +
string.Format(GettextCatalog.GetPluralString("{0} Message", "{0} Messages",
msgs), msgs);
}
private void ItemToggled (object o, ToggledArgs args)
Modified: trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.mdp
===================================================================
--- trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.mdp
2006-08-29 11:36:36 UTC (rev 64507)
+++ trunk/monodevelop/Core/src/MonoDevelop.Ide/MonoDevelop.Ide.mdp
2006-08-29 11:59:22 UTC (rev 64508)
@@ -127,7 +127,6 @@
<File name="./MonoDevelop.Ide.Gui.Dialogs/GacReferencePanel.cs"
subtype="Code" buildaction="Compile" />
<File name="./MonoDevelop.Ide.Gui.Dialogs/ProjectReferencePanel.cs"
subtype="Code" buildaction="Compile" />
<File name="./MonoDevelop.Ide.Gui.Dialogs/SelectReferenceDialog.cs"
subtype="Code" buildaction="Compile" />
- <File name="./MonoDevelop.Ide.Gui.Dialogs/WebReference.cs" subtype="Code"
buildaction="Compile" />
<File name="./MonoDevelop.Ide.Gui.Pads/DefaultMonitorPad.cs"
subtype="Code" buildaction="Compile" />
<File name="./MonoDevelop.Ide.Gui.Pads/OpenTaskView.cs" subtype="Code"
buildaction="Compile" />
<File name="./MonoDevelop.Ide.Gui.Pads.ClassPad/ClassData.cs"
subtype="Code" buildaction="Compile" />
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
