Author: anagappan
Date: 2006-11-28 08:21:25 -0500 (Tue, 28 Nov 2006)
New Revision: 68578

Modified:
   trunk/mcs/class/System.Data/System.Data.Common/ChangeLog
   trunk/mcs/class/System.Data/System.Data.Common/DataAdapter.cs
   trunk/mcs/class/System.Data/System.Data.Common/DbDataAdapter.cs
Log:
2006-11-28  Nagappan A  <[EMAIL PROTECTED]>

        * DbDataAdapter.cs: Removed bogus MonoTODOs

        * DataAdapter.cs: Removed bogus MonoTODOs



Modified: trunk/mcs/class/System.Data/System.Data.Common/ChangeLog
===================================================================
--- trunk/mcs/class/System.Data/System.Data.Common/ChangeLog    2006-11-28 
13:06:44 UTC (rev 68577)
+++ trunk/mcs/class/System.Data/System.Data.Common/ChangeLog    2006-11-28 
13:21:25 UTC (rev 68578)
@@ -1,3 +1,9 @@
+2006-11-28  Nagappan A  <[EMAIL PROTECTED]>
+
+       * DbDataAdapter.cs: Removed bogus MonoTODOs
+
+       * DataAdapter.cs: Removed bogus MonoTODOs
+       
 2006-11-15  Nagappan A  <[EMAIL PROTECTED]>
 
        * DbDataAdapter.cs (FillFromReader): Implemented missing API to

Modified: trunk/mcs/class/System.Data/System.Data.Common/DataAdapter.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.Common/DataAdapter.cs       
2006-11-28 13:06:44 UTC (rev 68577)
+++ trunk/mcs/class/System.Data/System.Data.Common/DataAdapter.cs       
2006-11-28 13:21:25 UTC (rev 68578)
@@ -223,11 +223,13 @@
 
 
 #if NET_2_0
+               [MonoTODO]
                public virtual int Fill (DataSet dataSet)
                {
                        throw new NotSupportedException ();
                }
 
+               [MonoTODO]
                protected virtual int Fill (DataTable dataTable, IDataReader 
dataReader)
                {
                        throw new NotImplementedException ();
@@ -269,7 +271,6 @@
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                protected bool HasTableMappings ()
                {
                        return (TableMappings.Count != 0);
@@ -282,11 +283,10 @@
 
                }
 
-               [MonoTODO]
                [EditorBrowsable (EditorBrowsableState.Never)]
                public void ResetFillLoadOption ()
                {
-                       //what else ??
+                       //FIXME: what else ??
                        FillLoadOption = LoadOption.OverwriteChanges;
                }
 

Modified: trunk/mcs/class/System.Data/System.Data.Common/DbDataAdapter.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.Common/DbDataAdapter.cs     
2006-11-28 13:06:44 UTC (rev 68577)
+++ trunk/mcs/class/System.Data/System.Data.Common/DbDataAdapter.cs     
2006-11-28 13:21:25 UTC (rev 68578)
@@ -66,7 +66,6 @@
                {
                }
 
-               [MonoTODO]
                protected DbDataAdapter(DbDataAdapter adapter) : base(adapter)
                {
                }
@@ -534,7 +533,6 @@
                        return FillSchema (dataSet, schemaType, 
((IDbDataAdapter) this).SelectCommand, srcTable, CommandBehavior.Default);
                }
 
-               [MonoTODO ("Verify")]
                protected virtual DataTable FillSchema (DataTable dataTable, 
SchemaType schemaType, IDbCommand command, CommandBehavior behavior) 
                {
                        if (dataTable == null)
@@ -570,7 +568,6 @@
                        return dataTable;
                }
 
-               [MonoTODO ("Verify")]
                protected virtual DataTable[] FillSchema (DataSet dataSet, 
SchemaType schemaType, IDbCommand command, string srcTable, CommandBehavior 
behavior) 
                {
                        if (dataSet == null)
@@ -651,7 +648,6 @@
                // "array[ordinal of datatable column] == index of source 
column in data reader".
                // each column in the datatable has a mapping to a specific 
column in the datareader,
                // the int array represents this match.
-               [MonoTODO ("Test")]
                private int[] BuildSchema (IDataReader reader, DataTable table, 
SchemaType schemaType)
                {
                        return BuildSchema (reader, table, schemaType, 
MissingSchemaAction,
@@ -833,7 +829,6 @@
                        throw new NotImplementedException ();
                }
 
-               [MonoTODO]
                public int Update (DataRow[] dataRows) 
                {
                        if (dataRows == null)
@@ -947,7 +942,6 @@
                        return Update (rows, tableMapping);
                }
 
-               [MonoTODO]
                protected virtual int Update (DataRow[] dataRows, 
DataTableMapping tableMapping) 
                {
                        int updateCount = 0;

_______________________________________________
Mono-patches maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches

Reply via email to