Author: miguel
Date: 2006-11-28 17:31:11 -0500 (Tue, 28 Nov 2006)
New Revision: 68622
Modified:
trunk/mcs/class/System.Data/ChangeLog
trunk/mcs/class/System.Data/System.Data.SqlClient/SqlParameter.cs
trunk/mcs/class/System.Data/System.Data/DataRowCollection.cs
trunk/mcs/class/System.Data/System.Data/DataRowView.cs
Log:
2006-11-28 Miguel de Icaza <[EMAIL PROTECTED]>
* Rationalize use of MonoTODO as well.
Modified: trunk/mcs/class/System.Data/ChangeLog
===================================================================
--- trunk/mcs/class/System.Data/ChangeLog 2006-11-28 22:16:35 UTC (rev
68621)
+++ trunk/mcs/class/System.Data/ChangeLog 2006-11-28 22:31:11 UTC (rev
68622)
@@ -1,3 +1,7 @@
+2006-11-28 Miguel de Icaza <[EMAIL PROTECTED]>
+
+ * Rationalize use of MonoTODO as well.
+
2006-11-05 Vladimir Krasnov <[EMAIL PROTECTED]>
* System.Data20.vmwcsproj: added OleDbFactory.cs
Modified: trunk/mcs/class/System.Data/System.Data/DataRowCollection.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data/DataRowCollection.cs
2006-11-28 22:16:35 UTC (rev 68621)
+++ trunk/mcs/class/System.Data/System.Data/DataRowCollection.cs
2006-11-28 22:31:11 UTC (rev 68622)
@@ -391,5 +391,13 @@
if (ListChanged != null)
ListChanged (sender, args);
}
+
+#if NET_2_0
+ public override int Count {
+ get {
+ return base.Count;
+ }
+ }
+#endif
}
}
Modified: trunk/mcs/class/System.Data/System.Data/DataRowView.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data/DataRowView.cs 2006-11-28
22:16:35 UTC (rev 68621)
+++ trunk/mcs/class/System.Data/System.Data/DataRowView.cs 2006-11-28
22:31:11 UTC (rev 68622)
@@ -248,55 +248,54 @@
return attributes;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns String.Empty")]
string ICustomTypeDescriptor.GetClassName ()
{
return "";
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns null")]
string ICustomTypeDescriptor.GetComponentName ()
{
return null;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns null")]
TypeConverter ICustomTypeDescriptor.GetConverter ()
{
return null;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns null")]
EventDescriptor ICustomTypeDescriptor.GetDefaultEvent ()
{
return null;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns null")]
PropertyDescriptor ICustomTypeDescriptor.GetDefaultProperty ()
{
return null;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns null")]
object ICustomTypeDescriptor.GetEditor (Type editorBaseType)
{
return null;
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns an empty
collection")]
EventDescriptorCollection ICustomTypeDescriptor.GetEvents ()
{
return new EventDescriptorCollection(null);
}
- [MonoTODO]
+ [MonoTODO ("Not implemented. Always returns an empty
collection")]
EventDescriptorCollection ICustomTypeDescriptor.GetEvents
(Attribute [] attributes)
{
return new EventDescriptorCollection(null);
}
- [MonoTODO]
PropertyDescriptorCollection
ICustomTypeDescriptor.GetProperties ()
{
if (DataView == null) {
@@ -308,7 +307,7 @@
}
}
- [MonoTODO]
+ [MonoTODO ("It currently reports more descriptors than
necessary")]
PropertyDescriptorCollection
ICustomTypeDescriptor.GetProperties (Attribute [] attributes)
{
PropertyDescriptorCollection descriptors;
@@ -331,14 +330,14 @@
#region IDataErrorInfo implementation
string IDataErrorInfo.Error {
- [MonoTODO]
+ [MonoTODO("Not implemented, always returns
String.Empty")]
get {
return ""; // FIXME
}
}
string IDataErrorInfo.this[string columnName] {
- [MonoTODO]
+ [MonoTODO("Not implemented, always returns
String.Empty")]
get {
return ""; // FIXME
}
@@ -351,7 +350,6 @@
public event PropertyChangedEventHandler PropertyChanged;
- [MonoTODO ("to be tested..")]
void OnPropertyChanged (string propertyName)
{
if (PropertyChanged != null) {
Modified: trunk/mcs/class/System.Data/System.Data.SqlClient/SqlParameter.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.SqlClient/SqlParameter.cs
2006-11-28 22:16:35 UTC (rev 68621)
+++ trunk/mcs/class/System.Data/System.Data.SqlClient/SqlParameter.cs
2006-11-28 22:31:11 UTC (rev 68622)
@@ -809,7 +809,7 @@
}
#if NET_2_0
- [MonoTODO]
+ [MonoTODO ("Not implemented")]
public override void ResetDbType ()
{
throw new NotImplementedException ();
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
